Questions regarding productsets

[Jaroslaw Staniek]

Hello Friedrich & All,
I already like the productsets very much, just believe some tweaking
regarding defaults would be beneficial.

My questions raised just after re-configuring some build of Calligra.

1. To make code easier, do we need the old flags
(calligra_drop_products_on_old_flag lines) in the CMakeLists.txt file
in 2.9?
2. In CalligraProducts.cmake, there is:

---8x------
calligra_define_productset(KEXI "Full Kexi (for Desktop)"
    REQUIRES
        APP_KEXI
    OPTIONAL
        FEATURE_SCRIPTING
        PLUGIN_KEXI_SPREADSHEETMIGRATION
        PLUGIN_REPORTING
)
---8x------

Now from a point of view of casual user who compiles Calligra (or a
contributor who
packages it for a distro): I think it's too easy to miss the optional
stuff here, and thus users will never see them. PLUGIN_REPORTING is
pretty standard subproduct of Kexi, missing it means non
fully-functional. Even FEATURE_SCRIPTING, while experimental, we have
enabled by default.

Similarly, PLUGIN_DEFAULTTOOLS is optional everywhere including Words.

It looks like default build is configured as "minimal but working" and
not "fully functional default".

Solutions?

Am I right that mostly things that we don't want to have enabled by
default should be optional?


3. I used -DPRODUCTSET="KEXI SHEETS" on a system  without eigen3. I
got APP_SHEET silently disabled. I think the build  should not
silently continue but stop with error if APP_SHEET is not optional.
And it is not since I have added SHEET explicitly to my productsets.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt for Tizen | http://qt-project.org/wiki/Tizen
 Qt Certified Specialist | http://www.linkedin.com/in/jstaniek