Review Request 118986: Show all possible file extensions in the file widget of database importer

Adam Pigg adam at piggz.co.uk
Sun Jun 29 22:33:37 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118986/#review61223
-----------------------------------------------------------



kexi/widget/KexiFileWidget.cpp
<https://git.reviewboard.kde.org/r/118986/#comment42641>

    ??


- Adam Pigg


On June 27, 2014, 11:08 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118986/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 11:08 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, harshita mistry, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Show all possible file extensions in the file widget of database importer
> 
> The extensions are grabbed from meta data of available migration plugins supporting files.
> This way, list of extensions no longer have to be hard-coded.
> 
> With coming ODB import, this is a need.
> 
> To make it all possible, migration lib no longer uses keximain, it's the other way around.
> 
> By the way, properly clear error status in migrate manager so previous failures do not affect result of further imports.
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiMainWindowIface.h 4ffd111fb321194380ca1a4088a8138971eb1eda 
>   kexi/core/KexiMigrateManagerInterface.h PRE-CREATION 
>   kexi/main/CMakeLists.txt e08981a9c72ff5371904efa3945fb86925447636 
>   kexi/main/KexiMainWindow.h a8f643ee01c7eb2659e09f78e48aa6b9be3337de 
>   kexi/main/KexiMainWindow.cpp 9f0127d1acec8c1b2f9baf8facbcde1a36be3375 
>   kexi/main/KexiMainWindow_p.h 9e1fd7d0337472d1e9b309c9810fbb4faf44d833 
>   kexi/migration/CMakeLists.txt 2478b103ce31a561fa716473725655dce8719516 
>   kexi/migration/importtablewizard.cpp 219adac5d13d230e83ecb5490d274a355789e110 
>   kexi/migration/migratemanager.h 967c1baa9ae49fabd0d4a1e775afa69e30801e87 
>   kexi/migration/migratemanager.cpp 92a8877b31e388777d1e9b0096f1b83cabb2238a 
>   kexi/widget/KexiFileWidget.cpp 86e472b5a7f64ba0aba0a6ea30b80616d2d2b99e 
> 
> Diff: https://git.reviewboard.kde.org/r/118986/diff/
> 
> 
> Testing
> -------
> 
> Extenstions show properly
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140629/d623617c/attachment.htm>


More information about the calligra-devel mailing list