Review Request 119002: Added focusing item after it is added in Kexi's report

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119002/#review61213
-----------------------------------------------------------

Ship it!


Good job! 
One thing, to avoid misleading the reader, in the summary of the commit I would use "selecting" term, not "focusing".

The fix fits to 2.8 and master.


libs/koreport/wrtembed/KoReportDesigner.cpp
<https://git.reviewboard.kde.org/r/119002/#comment42636>

    If you change the type to KoReportItemBase here, you won't have to use the ugly dynamic_cast in line 892. Let's kill as many dynamic_casts as possible!
    
    Then of course line 882 is a problem. 
    Case to KoReportItemBase there. I propose another junior job: separately in this context: make createDesignerInstance() return KoReportItemBase* instead of QObject*.


- Jarosław Staniek


On June 29, 2014, 4:39 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119002/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 4:39 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Bugs: 334967
>     http://bugs.kde.org/show_bug.cgi?id=334967
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> After inserting item in reports it is selected
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.cpp bad3295 
> 
> Diff: https://git.reviewboard.kde.org/r/119002/diff/
> 
> 
> Testing
> -------
> 
> After adding item in reports it is focused and it's properties are active
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140629/eccae67e/attachment.htm>