Review Request 118983: Fix crash and import failures for ODS import to Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118983/
-----------------------------------------------------------

Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Bugs: 309267 and 336814
    http://bugs.kde.org/show_bug.cgi?id=309267
    http://bugs.kde.org/show_bug.cgi?id=336814


Repository: calligra


Description
-------

Fix crash and import failures for ODS import to Kexi

1. Copying contents of table(s) always fails; as it's unimplemented, now at least silently succeeds.
2. Sheets can now contain column names that cannot be identifiers. Sample document: https://bugs.kde.org/show_bug.cgi?id=309267#attach_74887). 
3. Sheet can contain non-unique column names. If a column is duplicated, add _N to it, where N is subsequent integer, increased from 1 until the name become unique.


Diffs
-----

  plugins/kexi/spreadsheet/spreadsheetmigrate.h 00da0fab072bc3103a60ccad13d1bb2878ef705b 
  plugins/kexi/spreadsheet/spreadsheetmigrate.cpp d9ab7c0168a5fbf96d32017a1c52d78d3fd02faa 

Diff: https://git.reviewboard.kde.org/r/118983/diff/


Testing
-------

Importing works for the sample file


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140627/044da688/attachment.htm>