Review Request 118532: Proper handling of sections for Words and Author

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118532/#review60814
-----------------------------------------------------------



cmake/productsets/words.cmake
<https://git.reviewboard.kde.org/r/118532/#comment42386>

    Hi Denis,
    
    in the meantime behind your back the product system was slightly change, so the old way of defining product sets does not work anymore. For the new syntax see the other files in that directory now, and also have a look at /CalligraProducts.cmake .
    
    There you will actually find that the predefined product sets AUTHOR and WORDS now have all the usually wanted plugins already listed as OPTIONAL requirements. And the PRODUCTSET cmake flag now also supports listing of multiple sets, products and features, so you could also call cmake -DPRODUCTSET="AUTHOR WORDS" to have both product sets built but nothing else.
    
    More background information at http://frinring.wordpress.com/2014/06/17/managing-internal-dependencies-in-a-build-of-calligra/
    
    So in the end you no want to add a special product set I guess, so this file could be removed from this patch.


- Friedrich W. H. Kossebau


On June 23, 2014, 9:07 a.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118532/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 9:07 a.m.)
> 
> 
> Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir Turthra Jensen.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This adds proper section handling to code. It concentrates on managing to not break section structure during editing of text.
> Patch fixes many things:
> 1) Insertion of text into sections
> 2) Deletion of text with sections
> 3) Cut, paste of text with sections
> 4) Applying style doesn't remove section info
> 5) WORDS product set added for fast building of Words and Author
> 6) Sections visual indication (need improvements)
> 
> Future TODOS:
> 1) improving section indication (DONE)
> 2) ability to insert section (DONE)
> 3) adding unittests
> 4) change icon for "New section" functionality
> 5) we should read "Undo New section" in edit, after inserting new one
> 6) fix indication of sections for multipage documents
> 
> 
> Diffs
> -----
> 
>   cmake/productsets/words.cmake PRE-CREATION 
>   libs/flake/KoCanvasResourceManager.h 2ad1c6f 
>   libs/flake/KoShapePaintingContext.h a7d15fd 
>   libs/flake/KoShapePaintingContext.cpp 28ce859 
>   libs/kotext/CMakeLists.txt 44fa937 
>   libs/kotext/KoSection.h ac3fdd8 
>   libs/kotext/KoSection.cpp ca414b0 
>   libs/kotext/KoSectionEnd.h PRE-CREATION 
>   libs/kotext/KoSectionEnd.cpp PRE-CREATION 
>   libs/kotext/KoSectionUtils.h PRE-CREATION 
>   libs/kotext/KoSectionUtils.cpp PRE-CREATION 
>   libs/kotext/KoTextEditor.h 1fe289b 
>   libs/kotext/KoTextEditor.cpp 574e803 
>   libs/kotext/KoTextEditor_format.cpp a82352d 
>   libs/kotext/KoTextPaste.cpp de89bd8 
>   libs/kotext/commands/DeleteCommand.h f9dd2ef 
>   libs/kotext/commands/DeleteCommand.cpp 391495e 
>   libs/kotext/opendocument/KoTextLoader.h ca92573 
>   libs/kotext/opendocument/KoTextLoader.cpp bf3044e 
>   libs/kotext/opendocument/KoTextWriter_p.cpp c03cebb 
>   libs/kundo2/kundo2magicstring.h f60f2a7 
>   libs/odf/KoOdfPaste.cpp 1e46546 
>   libs/textlayout/KoTextDocumentLayout.h 45a9ccb 
>   libs/textlayout/KoTextLayoutArea.h f1b900a 
>   libs/textlayout/KoTextLayoutArea_paint.cpp 2982c60 
>   plugins/textshape/TextShape.cpp 3b25ffe 
>   plugins/textshape/TextTool.h 3409292 
>   plugins/textshape/TextTool.cpp ae51513 
>   plugins/textshape/dialogs/SimpleInsertWidget.cpp c2f083f 
>   plugins/textshape/dialogs/SimpleInsertWidget.ui 4b9c639 
>   words/part/CMakeLists.txt 41f675b 
>   words/part/KWApplicationConfig.h 87f1016 
>   words/part/KWApplicationConfig.cpp 1df6557 
>   words/part/KWFactory.cpp 9894f40 
>   words/part/KWView.h 50ee760 
>   words/part/KWView.cpp 6456d1f 
>   words/part/dockers/KWDebugDocker.h PRE-CREATION 
>   words/part/dockers/KWDebugDocker.cpp PRE-CREATION 
>   words/part/dockers/KWDebugDockerFactory.h PRE-CREATION 
>   words/part/dockers/KWDebugDockerFactory.cpp PRE-CREATION 
>   words/part/dockers/KWDebugWidget.h PRE-CREATION 
>   words/part/dockers/KWDebugWidget.cpp PRE-CREATION 
>   words/part/words.rc c3a9822 
> 
> Diff: https://git.reviewboard.kde.org/r/118532/diff/
> 
> 
> Testing
> -------
> 
> I have tested all functionality with emphasis on deletion. It has the most complicated code and need very good testing.
> You can use LibreOffice Writer to create document with sections and then test editing it in words. And I will attach one I've used.
> 
> 
> File Attachments
> ----------------
> 
> File for testing
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/f87d4ce2-3ab9-48a4-a880-4caa586790fc__Test-orig.odt
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140623/f3181b52/attachment.htm>