Review Request 118187: Make it possible to specify multiple product sets so KEXI+SHEETS works

Jarosław Staniek staniek at kde.org
Tue Jun 17 11:36:36 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118187/
-----------------------------------------------------------

(Updated June 17, 2014, 10:36 a.m.)


Status
------

This change has been discarded.


Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Make it possible to specify multiple product sets so KEXI+SHEETS works

For example -DPRODUCTSET="KEXI SHEETS" builds full Kexi and Sheets.
Therefore hard to maintain custom product definitions are not needed anymore,
e.g. kexi+sheets.cmake.

In order to make Kexi & Sheets work on a clean build, I also added necessary plugins to sheets.cmake.

If that's OK, we can update the docs too and the wiki of course, especially http://community.kde.org/Calligra/Building/Building_Calligra#Specific_Product_Sets.


Diffs
-----

  cmake/productsets/sheets.cmake 5de210338d0d37cdfa9b89b10bee720deb1a7782 
  cmake/productsets/osx.cmake 8e32b1323fac47a3d9ae7bd549cd9d59057e631f 
  cmake/productsets/krita.cmake 2c814d3b2f8023b3260d46f1c8fcc0a9f29d34f9 
  cmake/productsets/kexi.cmake 7dd234530c0205f8cc788a567e57f40b072f6748 
  cmake/productsets/kexi+sheets.cmake 3fe2f48c92c1b09a2e4ba0be81a1e9a1cba11460 
  cmake/productsets/desktop.cmake 97ff7e8b8db89a6197db327b6ea00207a2fd0171 
  cmake/productsets/creative.cmake 2b8fc45bed2641163376cc7a600fe8f928a571ef 
  cmake/productsets/braindump.cmake 9d32a327b5b2ff615b17269ebfcf4c00c5dac7af 
  cmake/productsets/all.cmake 778f9c088601e13a3608e410a6ca141e51f97578 
  cmake/productsets/active.cmake 089a085eb63996816f33f485d0c2166fe2f6f31f 
  cmake/modules/CalligraProductSetMacros.cmake 697c046d4642cd4158c6f2e5307e269579d40431 
  CMakeLists.txt b65d702f62593651da4c488a56edb8e94cda9620 

Diff: https://git.reviewboard.kde.org/r/118187/diff/


Testing
-------

works as explained, and it's superconvenient


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140617/d5afc9b3/attachment.htm>


More information about the calligra-devel mailing list