Review Request 118744: Unselecting text in kexidbtextedit when focus is out

Jarosław Staniek staniek at kde.org
Sun Jun 15 20:19:33 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118744/#review60133
-----------------------------------------------------------


Cool, minor fixes left.


kexi/plugins/forms/widgets/kexidbtextedit.h
<https://git.reviewboard.kde.org/r/118744/#comment41898>

    * event -> *e



kexi/plugins/forms/widgets/kexidbtextedit.cpp
<https://git.reviewboard.kde.org/r/118744/#comment41899>

    add copyright here and in the .h



kexi/plugins/forms/widgets/kexidbtextedit.cpp
<https://git.reviewboard.kde.org/r/118744/#comment41897>

    still there's 'this' :)


- Jarosław Staniek


On June 15, 2014, 12:56 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118744/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 12:56 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Bugs: 336054
>     http://bugs.kde.org/show_bug.cgi?id=336054
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> QTextEdit does not provide deselect method therefore it had to be implemented by operating with the cursor. It required reimplementing focusOutEvent and focusInEvent in order to hide/show cursor.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/widgets/kexidbtextedit.h b8e30df 
>   kexi/plugins/forms/widgets/kexidbtextedit.cpp eb0bb4e 
> 
> Diff: https://git.reviewboard.kde.org/r/118744/diff/
> 
> 
> Testing
> -------
> 
> In Kexi form multiple text editor elements can be added and when focus changes to another element, text in not used anymore text editor is not selected
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140615/d3b1fc4d/attachment.htm>


More information about the calligra-devel mailing list