Review Request 118757: Enable building Kexi in -DKEXI_MOBILE mode

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118757/#review60132
-----------------------------------------------------------


Cool, minor notes added.


kexi/mobile/KexiMobileMainWindow.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41887>

    add Q_UNUSED() and add:
    
    //! part infos have to be collected at this stage
    
    (since this is important addition)



kexi/mobile/KexiMobileMainWindow.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41888>

    not needed



kexi/mobile/KexiMobileMainWindow.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41889>

    -> qWarning



kexi/mobile/KexiMobileWidget.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41890>

    -> qWarning



kexi/mobile/KexiMobileWidget.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41891>

    -> qWarning
    project can be 0 ==> crash



kexi/mobile/main.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41892>

    remove



kexi/mobile/main.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41893>

    Office -> Suite



kexi/mobile/main.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41894>

    -> LGPL according to our intent



libs/db/drivermanager.cpp
<https://git.reviewboard.kde.org/r/118757/#comment41895>

    please remove changes to this file



plugins/kexi/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118757/#comment41896>

    IF -> if


- Jarosław Staniek


On June 15, 2014, 9:37 a.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118757/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 9:37 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Enable building Kexi in -DKEXI_MOBILE mode
> 
> Several API changes have been made which broke compilation
> Added a call to init all the kexi parts
> Disabled the kspread migrate plugin as migrate is not enabled in mobile mode
> 
> 
> Diffs
> -----
> 
>   kexi/mobile/CMakeLists.txt c2b3543f62f1db5ced45bae1d3f59b047c1c4efc 
>   kexi/mobile/KexiMobileMainWindow.h 56a94f05cf9133aca001dc519208b4069d05f50f 
>   kexi/mobile/KexiMobileMainWindow.cpp c859c343f964f62894f703cb0802aaf0e1e29faa 
>   kexi/mobile/KexiMobileNavigator.h 3ae3b916d84343b5475a6e3f7f82acb650457773 
>   kexi/mobile/KexiMobileWidget.cpp b67d466d9177942285113675055c18a30d430267 
>   kexi/mobile/main.cpp c359ed882276e3b259806b858cf7f1385e632818 
>   kexi/widget/CMakeLists.txt 8a30895fab21ca268d9d4a5112630adff6e4d8a1 
>   libs/db/drivermanager.cpp ddca64e3aeee8b9d8c9c512053a8c0c38b1ad078 
>   plugins/kexi/CMakeLists.txt e32a2911f908fdfc777cd0601c1b895f6ce290fe 
> 
> Diff: https://git.reviewboard.kde.org/r/118757/diff/
> 
> 
> Testing
> -------
> 
> Kexi mobile builds, runs and shows reports
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140615/f4567c9d/attachment.htm>