Review Request 118631: Added shortcut combination Ctrl + S to perform Save/Save As operation in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118631/#review59738
-----------------------------------------------------------


Good job!
You actually inspired me to look further. Ctrl+S is a global action like the menu actions (eg. Ctrl+O, Ctrl+N), so I propose to reuse existing method that does similar hack:

http://paste.kde.org/pm89fwxqi

In the improved form of setupMainMenuActionShortcut(), does not force to mention slot name again and connects directly to action that is already available (via trigger()).
By the way I updated all the calls to setupMainMenuActionShortcut().

Seems to work.

As a bonus, alternate shortcut (KDE can support primary and alternate shortcut for each action), is now supported.


- Jarosław Staniek


On June 9, 2014, 10:52 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118631/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 10:52 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Bugs: 334587
>     http://bugs.kde.org/show_bug.cgi?id=334587
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Adds shortcut Ctrl+S to save changes within any changed context (tables, forms, scripts, queries, reports). It required suppresing action file_save of KTextEditor that is used as text editor for scripts and queries
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp e90a66f 
>   kexi/widget/kexieditor.cpp d3340f0 
> 
> Diff: https://git.reviewboard.kde.org/r/118631/diff/
> 
> 
> Testing
> -------
> 
> Ctrl+S combination calls Save/Save As in proper context when working with Kexi
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140611/a5d5d2a9/attachment.htm>