Review Request 118582: Fix crash when removing a Database Connection.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118582/#review59531
-----------------------------------------------------------



kexi/widget/KexiConnectionSelectorWidget.cpp
<https://git.reviewboard.kde.org/r/118582/#comment41484>

    From docs of QTreeWidgetItem::~QTreeWidgetItem():
    "Destroys this tree widget item.
    The item will be removed from QTreeWidgets to which it has been added. This makes it safe to delete an item at any time."
    
    So I suppose, "delete item" is enough instead to all this code. Please try this and if OK, please update the review. The comments also can be removed.
    


- Jarosław Staniek


On June 6, 2014, 12:53 a.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118582/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 12:53 a.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, and Tomasz Olszak.
> 
> 
> Bugs: 315288
>     http://bugs.kde.org/show_bug.cgi?id=315288
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix crash when removing a Database Connection.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/KexiConnectionSelectorWidget.cpp c06c2ab93863e8ea8a973d4e76752f55f131968d 
> 
> Diff: https://git.reviewboard.kde.org/r/118582/diff/
> 
> 
> Testing
> -------
> 
> Manualy tested
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140607/2b4f4742/attachment.htm>