[Marble-devel] Review Request 118495: Marble input handling refactor. Support for mouse, touch and pinch in MarbleQuickItem.

Friedrich W. H. Kossebau kossebau at kde.org
Thu Jun 5 18:22:42 BST 2014


Hi,

(cc: to calligra-devel just for heads-up, please remove when replying)

Am Dienstag, 3. Juni 2014, 11:49:04 schrieb Adam Dabrowski:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118495/
> -----------------------------------------------------------
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Functionalities:
> - Mouse, touch and pinch input handling for MarbleQuickItem (keyboard was
> enabled earlier)
> 
> Other changes:
> - Refactored input handling to reuse code, broke into smaller pieces
> (functions) - Extended the example (marbleQuick2)
> 
> Known issues:
> - Some refactoring still should be done around input classes
> - Inertial rotation is disabled by default in MarbleQuickItem because of
> some issues (mostly touch-related). However, issues are rather minor so
> feel free to enable it back.

This API change sadly broke at least the Calligra build on build.kde.org. At 
least the code which uses Marble like this:
https://projects.kde.org/projects/calligra/repository/revisions/master/entry/plugins/semanticitems/location/KoRdfLocationEditWidget.cpp#L80

How should that best be changed to work with the new API? And which 
MARBLE_VERSION to check against?

Cheers
Friedrich



More information about the calligra-devel mailing list