Review Request 118519: Fix crash when accessing a query with duplicated table names

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118519/#review59245
-----------------------------------------------------------


I was wondering....this seems like it would suit a unit-test.  I know we arent set up for unit-test yet but we could start somewhere.  2 tests could show a valid query passing, and an incorrect query returning the appropriate failure.  Then in the future, we know that future changes wont break.

- Adam Pigg


On June 4, 2014, 11:16 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118519/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:16 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 315852
>     http://bugs.kde.org/show_bug.cgi?id=315852
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix crash when accessing a query with duplicated table names
> 
> Example query that crashed: SELECT t.foo FROM t, t.
> Now error message is displayed so user can fix the statement.
> 
> FIXED-IN:2.8.4
> 
> 
> Diffs
> -----
> 
>   libs/db/expression.cpp c59855e1e9e4b972352b58b2037c9187a251ed8f 
> 
> Diff: https://git.reviewboard.kde.org/r/118519/diff/
> 
> 
> Testing
> -------
> 
> No longer crashes for tested queries, we're no longer using dangerous function at() in this context
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140604/2c042a39/attachment.htm>