Review Request 118532: Proper handling of sections for Words and Author
Denis Kuplyakov
dener.kup at gmail.com
Wed Jun 4 17:30:35 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118532/
-----------------------------------------------------------
Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir Turthra Jensen.
Repository: calligra
Description
-------
This adds proper section handling to code. It concentrates on managing to not break section structure during editing of text.
Patch fixes many things:
1) Insertion of text into sections
2) Deletion of text with sections
3) Cut, paste of text with sections
4) Applying style doesn't remove section info
5) WORDS product set added for fast building of Words and Author
6) Sections visual indication (need improvements)
Future TODOS:
1) improving section indication
2) ability to insert section
3) adding unittests
Diffs
-----
cmake/productsets/words.cmake PRE-CREATION
libs/kotext/KoSection.h ac3fdd8
libs/kotext/KoSection.cpp ca414b0
libs/kotext/KoTextEditor.cpp efc9dd0
libs/kotext/KoTextEditor_format.cpp dacc19a
libs/kotext/KoTextPaste.cpp de89bd8
libs/kotext/commands/DeleteCommand.h f9dd2ef
libs/kotext/commands/DeleteCommand.cpp 5cb92527
libs/kotext/opendocument/KoTextLoader.h ca92573
libs/kotext/opendocument/KoTextLoader.cpp bf3044e
libs/kotext/opendocument/KoTextWriter_p.cpp c03cebb
libs/odf/KoOdfPaste.cpp 1e46546
libs/textlayout/KoTextLayoutArea.h f1b900a
libs/textlayout/KoTextLayoutArea_paint.cpp 2982c60
words/part/CMakeLists.txt 2bf1b0b
words/part/KWFactory.cpp 9894f40
words/part/dockers/KWDebugDocker.h PRE-CREATION
words/part/dockers/KWDebugDocker.cpp PRE-CREATION
words/part/dockers/KWDebugDockerFactory.h PRE-CREATION
words/part/dockers/KWDebugDockerFactory.cpp PRE-CREATION
words/part/dockers/KWDebugWidget.h PRE-CREATION
words/part/dockers/KWDebugWidget.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/118532/diff/
Testing
-------
I have tested all functionality with emphasis on deletion. It has the most complicated code and need very good testing.
You can use LibreOffice Writer to create document with sections and then test editing it in words. And I will attach one I've used.
File Attachments
----------------
File for testing
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/f87d4ce2-3ab9-48a4-a880-4caa586790fc__Test-orig.odt
Thanks,
Denis Kuplyakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140604/c20f8340/attachment.htm>
More information about the calligra-devel
mailing list