[kexi] [Bug 334093] Names of newly added tables and queries not properly sorted in forms data source combo

[Jaroslaw Staniek]

Wojciech,
Nice, just one minor remark. The commit message should better mention the
summary of the bug in the 1st line, i.e.
 "Properly sort newly added tables and queries in forms data source combo"
And primarily, it should explain *why* it exists, *not* what is being done.

Always think about commit message as about input to the official changelog.


Thiago has explained it nicely:
https://plus.google.com/u/0/+ThiagoMacieira/posts/CF5VKSnXXTT



On 3 June 2014 23:33, Wojciech Kosowicz <pcellix at gmail.com> wrote:

>  Wojciech Kosowicz <pcellix at gmail.com> changed bug 334093
> <https://bugs.kde.org/show_bug.cgi?id=334093>
>  What Removed Added  Latest Commit
> http://commits.kde.org/calligra/f3949bc88b3a3266980c7e405617dac6a3360c06
> http://commits.kde.org/calligra/5a4e7a9e04273635cd50899f4104c51e37b0a045
>
>  *Comment # 6 <https://bugs.kde.org/show_bug.cgi?id=334093#c6> on bug
> 334093 <https://bugs.kde.org/show_bug.cgi?id=334093> from Wojciech Kosowicz
> <pcellix at gmail.com> *
>
> Git commit 5a4e7a9e04273635cd50899f4104c51e37b0a045 by Wojciech Kosowicz.
> Committed on 03/06/2014 at 21:24.
> Pushed by wkosowicz into branch 'master'.
>
> Change of addItem to insertItem in KexiDataSourceComboBox slot
>
> In slotNewItemStored of KexiDataSourceComboBox there was called addItem
> method that adds to the end of combobox. Method insertItem should be
> called instead so that items are in correct order
> FIXED-IN: 2.8.4
> REVIEW: 118485
>
> M  +2    -2    kexi/widget/KexiDataSourceComboBox.cpp
> http://commits.kde.org/calligra/5a4e7a9e04273635cd50899f4104c51e37b0a045
>
>  ------------------------------
> You are receiving this mail because:
>
>    - You are on the CC list for the bug.
>    - You are watching someone on the CC list of the bug.
>    - You are watching the assignee of the bug.
>
>


-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt for Tizen | http://qt-project.org/wiki/Tizen
 Qt Certified Specialist | http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140603/43ae8fcc/attachment.htm>