Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118485/#review59109
-----------------------------------------------------------


Congratz! Please push to calligra/2.8 and master.

- Jarosław Staniek


On June 3, 2014, 9:09 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118485/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 9:09 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 334093
>     http://bugs.kde.org/show_bug.cgi?id=334093
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> In slotNewItemStored of KexiDataSourceComboBox there was called addItem method that adds to the end of combobox. Method insertItem should be called instead so that items are in correct order
> 
> 
> Diffs
> -----
> 
>   kexi/widget/KexiDataSourceComboBox.cpp 1ccd0ea 
> 
> Diff: https://git.reviewboard.kde.org/r/118485/diff/
> 
> 
> Testing
> -------
> 
> After adding new Query or Table inside Form's DataSource combobox newly added positions are sorted in alphabetical order
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140603/ba8d94d7/attachment.htm>