Review Request 119529: Krita: Add labels for floating input controls

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119529/#review63488
-----------------------------------------------------------


The change to the layerbox slider makes the slider much higher -- I don't think we want that.

The color-to-alpha change is good, I'll push that.

For the compositeop option, I agree with swapping eraser and the label, but now that I look at it with a fresh perspective, I think that the label looks too much like a button! But it did look like that, so that's not a problem.

For the autobrush labels: I think that they need colons according to the KDE style guide -- though I'm actually not sure! But the rest of the labels in that widget have colons.

For the custom brush: there's something weird here and the comboboxes have gotten really high!

The curve option label is a good addition, but I think that the layout can be improved by putting the label and the slider in one horizontal layout so there's not so much space between label and slider.

- Boudewijn Rempt


On July 29, 2014, 1:39 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119529/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 1:39 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Krita - Add labels for Brush Engine and layer window
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/libpaintop/kis_curve_option_widget.cpp c3ea0e8 
>   krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui d52b2f8 
>   krita/plugins/filters/colors/wdgcolortoalphabase.ui 40082bc 
>   krita/plugins/paintops/libpaintop/forms/wdgCompositeOpOption.ui 3b72a38 
>   krita/plugins/paintops/libpaintop/forms/wdgautobrush.ui 2f56bc1 
>   krita/plugins/paintops/libpaintop/forms/wdgcurveoption.ui ee8d229 
>   krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui 1c1a21b 
> 
> Diff: https://git.reviewboard.kde.org/r/119529/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140730/ae1c715e/attachment.htm>