Review Request 119496: Log explicitely why a product was dropped

Sun Jul 27 16:55:55 BST 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119496/
-----------------------------------------------------------

(Updated July 27, 2014, 3:55 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra.

Repository: calligra

Description
-------

The current build system is slightly unprecise about which external dep is missing, there is only one generic string for each product if one or more of the external deps was/were missing. E.g. "libodfgen|libetonyek|librevenge devel not found" or "SharedMimeInfo|libeigen3|libexiv2|lcms|boost-system devel not found".

This patch changes that by adding a new macro "calligra_drop_product_on_bad_condition" and adapting the current product-dropping-due-to-bad-external-deps code. As side effect it gives a nice listing of external deps for each product.

Any better name for "calligra_drop_product_on_bad_condition"?

(Also brings consistent handling of Xinput_FOUND as TRUE for Windows and OSX)

Diffs
-----

  CMakeLists.txt f76746c 
  cmake/modules/CalligraProductSetMacros.cmake bdca16c 

Diff: https://git.reviewboard.kde.org/r/119496/diff/

Testing
-------

Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140727/6c3ce492/attachment.htm>