Review Request 119136: Fix issue with resolving version of plugins (at least) on Linux

[Jarosław Staniek]

> On July 11, 2014, 9:53 p.m., Adam Pigg wrote:
> > Ship It!

Thanks, I will just need more time to integrate with Boud's changes for Calligra plugins.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119136/#review62151
-----------------------------------------------------------


On July 5, 2014, 9:17 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119136/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 9:17 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix issue with resolving version of plugins (at least) on Linux
> 
> Use C function instead of int member.
> By the way simplify code using wrapper class.
> 
> 
> Diffs
> -----
> 
>   kexi/kexidb/drivers/sybase/sybasedriver.cpp e2c9d52dff66f9d72937a924ff681f25781529f8 
>   kexi/kexidb/drivers/xbase/xbasedriver.cpp f3f5f49d63e9de2bf035a909f3ca1020cce31d52 
>   kexi/migration/keximigrate.h 606d58b318a8a7bc57e57bc492f58bc321c34785 
>   kexi/migration/keximigrate_p.h 697723212463489008026092fba029cc2f6eb2a7 
>   kexi/migration/mdb/src/keximdb/mdbmigrate.h 320c3e0e90fb29d1157d506ae3bb4b714c0df77a 
>   kexi/migration/mdb/src/keximdb/mdbmigrate.cpp af8e432b0c3d4ddf42d52c860efa68903b1345f9 
>   kexi/migration/migratemanager.cpp 0a52a738d6a4934691a575a91b80cc7dfe4b759a 
>   kexi/migration/mysql/mysqlmigrate.h 0a0bd2bf6022ba2f33572ff17692494ed3578f35 
>   kexi/migration/mysql/mysqlmigrate.cpp d511d159d400c38281335e20522d816414e6c06f 
>   kexi/migration/pqxx/pqxxmigrate.h 1870cd2b552d65acaec5c073af8f23b1c1c24948 
>   kexi/migration/pqxx/pqxxmigrate.cpp ecd987381e5e53c1ddf689e81ee8ccd0e8bdb8e6 
>   kexi/migration/sybase/sybasemigrate.h 5bdbb879b3162ead8fddca20997abc4d7c379904 
>   kexi/formeditor/widgetfactory.h 2a8fb7f49878186a0c8bd24d70f47ded3fe1f8b2 
>   libs/db/driver_p.h 62a23dbd7909f0c61b0a81b55c88e71ffc9f0acc 
>   libs/db/drivermanager.cpp ddca64e3aeee8b9d8c9c512053a8c0c38b1ad078 
>   libs/db/drivers/sqlite/sqlitedriver.cpp f28ec7f5cca8a3a51d44e2e9e01317048f96fa03 
>   libs/db/pluginloader.h PRE-CREATION 
>   libs/db/pluginloader.cpp PRE-CREATION 
>   libs/koreport/CMakeLists.txt 26d299c54189f5b402348baa1821f7641a1afd74 
>   libs/koreport/common/KoReportPluginInterface.h 32629afcabd4384ef3f64320065fe880e87130ab 
>   libs/koreport/common/KoReportPluginManager.cpp 246027cbd605aa69c8b7e9eb3ff01de5c712ac97 
>   plugins/kexi/spreadsheet/spreadsheetmigrate.cpp 03b728c0d27f3172bb56083fe4d7792866a2e2a4 
>   kexi/plugins/migration/keximigrationpart.cpp 21b0d88118b986930cc01298ce4ded7cafeb1696 
>   kexi/plugins/queries/kexiquerypart.cpp ded8537da76d21a55e5705ec4e60072edd956f42 
>   kexi/plugins/relations/kexirelationpartimpl.cpp 901038a10134a4e2406063048079e0615b14741e 
>   kexi/plugins/reports/kexireports.cpp 67b4189f621ad9c4c3b37fd6a1954a9fa2abdf92 
>   kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp 158b5acaf88ba05a7ab7a9649ef358d951892c25 
>   kexi/plugins/tables/kexitablepart.cpp 36c5922cf61e853b645fa98ed446e5ecdff590d8 
>   libs/db/CMakeLists.txt 419a06abb65d8995dd30149913960380a0b1b1c9 
>   libs/db/driver.h ed2469f158b9e0320645b4bd0cbc574e9a692dbf 
>   kexi/core/kexipart.h 172fd0e3a2b7139edc71c820a9ef7857492f64b1 
>   kexi/core/kexipartmanager.cpp 0aae8df91a84e11d3ecaf15f29d554cfd6892302 
>   kexi/formeditor/factories/containerfactory.cpp 20ade31ed167a040cb32022f9a21da46176c9f45 
>   kexi/formeditor/factories/stdwidgetfactory.cpp 45347aebc77145cd108bb21a7c0430131951615c 
>   kexi/migration/sybase/sybasemigrate.cpp 4967726bf4faf302326d4460bd64b587e0adc43a 
>   kexi/migration/txt/txtmigrate.h 8f87a8a9e92e3bec3d5a215ac5c19db3d82c7207 
>   kexi/migration/txt/txtmigrate.cpp 1cf380538e43172e6a32e039dfd7c30c210347a2 
>   kexi/migration/xbase/xbasemigrate.h 18ec11102a5a1d7751e0c2d0c9841d608e1be95e 
>   kexi/migration/xbase/xbasemigrate.cpp 403ea869b905e79a3585c6427e22964c79ba6422 
>   kexi/plugins/autoforms/KexiAutoForms.cpp 874e0817d61cdcfe1e9b03a39cb69ec859931e2a 
>   kexi/plugins/forms/kexidbfactory.cpp b320afdbaf03d99d7d1ca1c8d08bb3b93cabf2a7 
>   kexi/plugins/forms/kexiforms.cpp 24be71e15aadbe62adbe6bf9800fa9fd15eb2bd6 
>   kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp 5d9ecb9567b15484042f7a1d974b215dd8951c18 
>   kexi/plugins/forms/widgets/webbrowser/WebBrowserFactory.cpp fa768cced66d57583d9f14bf8cd74fbc1e6be667 
>   kexi/plugins/importexport/csv/kexicsv_importexportpart.cpp 7a6e8a833be005a269a80c1f444f1062c31882f1 
>   kexi/formeditor/widgetlibrary.cpp 883d6787574de63039035497d45ac175748f4b51 
>   kexi/kexidb/drivers/mysql/mysqldriver.cpp b243685ca9c71b25d46b8624fa06fa24652cdcbe 
>   kexi/kexidb/drivers/odbc/kodbcdriver.cpp 4be964588023c79d651b53d68b96b87b2418e2d9 
>   kexi/kexidb/drivers/oracle/oracledriver.cpp 64d1efc2d4bc9843949a188453c6c205bf4b7443 
>   kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 2f1ea2bb5bbd180b72eee959d66e82d1e56bb2ad 
> 
> Diff: https://git.reviewboard.kde.org/r/119136/diff/
> 
> 
> Testing
> -------
> 
> tested every type of plugin affected
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140714/4ce307ac/attachment.htm>