Review Request 119244: _C symbol breaks compilation on OpenBSD

[Vadim Zhukov]

> On Июль 13, 2014, 12:49 п.п., Boudewijn Rempt wrote:
> > Wow... This must mean that nobody has compiled Krita on OpenBSD since September 2010 :-).

I did - many times, but I was too lazy to send patches, sorry. Now that Calligra and many other modern KDE stuff got into official OpenBSD Ports tree, I started a cleanup campaign. :)


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119244/#review62235
-----------------------------------------------------------


On Июль 13, 2014, 12:48 п.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119244/
> -----------------------------------------------------------
> 
> (Updated Июль 13, 2014, 12:48 п.п.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The C (and therefore C++) standard mandates that symbol names starting by underscore ("_") sign are reserved and should not be used in applications. The kis_painter.cc uses "_C" and this breaks compilation on OpenBSD. The solution is renaming variables involved.
> 
> Please note that I do not have commit rights in KDE repos, so someone else should commit this patch if it gets accepted. Thanks.
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_painter.cc 4d40214 
> 
> Diff: https://git.reviewboard.kde.org/r/119244/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13.2
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140713/ceb61e5f/attachment.htm>