Review Request 119244: _C symbol breaks compilation on OpenBSD

Vadim Zhukov persgray at gmail.com
Sun Jul 13 09:48:52 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119244/
-----------------------------------------------------------

(Updated July 13, 2014, 8:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

The C (and therefore C++) standard mandates that symbol names starting by underscore ("_") sign are reserved and should not be used in applications. The kis_painter.cc uses "_C" and this breaks compilation on OpenBSD. The solution is renaming variables involved.

Please note that I do not have commit rights in KDE repos, so someone else should commit this patch if it gets accepted. Thanks.


Diffs
-----

  krita/image/kis_painter.cc 4d40214 

Diff: https://git.reviewboard.kde.org/r/119244/diff/


Testing
-------

OpenBSD/i386-CURRENT, KDE 4.13.2


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140713/5f96f810/attachment.htm>


More information about the calligra-devel mailing list