Review Request 119244: _C symbol breaks compilation on OpenBSD

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119244/#review62232
-----------------------------------------------------------

Ship it!


Hi, Vadim!

Thanks for a nice catch! Can you push the patch into master or we should do it on bahalf you you?

- Dmitry Kazakov


On Июль 12, 2014, 11:54 д.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119244/
> -----------------------------------------------------------
> 
> (Updated Июль 12, 2014, 11:54 д.п.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The C (and therefore C++) standard mandates that symbol names starting by underscore ("_") sign are reserved and should not be used in applications. The kis_painter.cc uses "_C" and this breaks compilation on OpenBSD. The solution is renaming variables involved.
> 
> Please note that I do not have commit rights in KDE repos, so someone else should commit this patch if it gets accepted. Thanks.
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_painter.cc 4d40214 
> 
> Diff: https://git.reviewboard.kde.org/r/119244/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13.2
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140713/3f39b5b9/attachment.htm>