Review Request 119150: Fix "Go to last record" button in KexiRecordNavigator being wrongly enabled on last record, when insertion was enabled

Jarosław Staniek staniek at kde.org
Thu Jul 10 22:24:27 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119150/#review62097
-----------------------------------------------------------


Worth pushing to 2.8 too...

- Jarosław Staniek


On July 10, 2014, 11:16 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119150/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 11:16 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When isInsertingEnabled was, the button was enabled on the last existing record, even if clicking did not result in any change.
> Calculating the current last record instead using editingIndicatorVisible aligned behaviour on button click and displayed state, where the last record was set to the new record if editing that had started.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/utils/kexirecordnavigator.cpp d7ac524 
> 
> Diff: https://git.reviewboard.kde.org/r/119150/diff/
> 
> 
> Testing
> -------
> 
> Tested with empty tables, non-empty tables and the use for the pages of reports.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140710/85dec3a1/attachment.htm>


More information about the calligra-devel mailing list