Review Request 119150: Fix "Go to last record" button in KexiRecordNavigator being wrongly enabled on last record, when insertion was enabled

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119150/#review61982
-----------------------------------------------------------

Ship it!


Ship It!

- Jarosław Staniek


On July 6, 2014, 8:04 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119150/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 8:04 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When isInsertingEnabled was, the button was enabled on the last existing record, even if clicking did not result in any change.
> Calculating the current last record instead using editingIndicatorVisible aligned behaviour on button click and displayed state, where the last record was set to the new record if editing that had started.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/utils/kexirecordnavigator.cpp d7ac524 
> 
> Diff: https://git.reviewboard.kde.org/r/119150/diff/
> 
> 
> Testing
> -------
> 
> Tested with empty tables, non-empty tables and the use for the pages of reports.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140709/7ecfcb14/attachment.htm>