Review Request 119075: Added printing reports to pdf feature in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119075/#review61942
-----------------------------------------------------------



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43131>

    Good but I propose to reduce the 4 comparisons and just add the lastExportPath to the list of function's parameters.


- Jarosław Staniek


On July 9, 2014, 12:23 a.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119075/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 12:23 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 335150
>     http://bugs.kde.org/show_bug.cgi?id=335150
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added button to report data view that prints report directly to pdf after selecting location 
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.h 1823cf8 
>   kexi/plugins/reports/kexireportview.cpp 2d84efc 
> 
> Diff: https://git.reviewboard.kde.org/r/119075/diff/
> 
> 
> Testing
> -------
> 
> After clicking and selecting save location pdf document with report data view content is created
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140708/6b5e16b8/attachment.htm>