Review Request 119075: Added printing reports to pdf feature in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119075/#review61859
-----------------------------------------------------------


Much better, still some notes...


kexi/core/KexiView.h
<https://git.reviewboard.kde.org/r/119075/#comment43068>

    I caused that you made mistake, this extra helper isn't needed since the export code is in Kexi. Just use window()->partItem() in the view :)



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43067>

    Why is this exportMenu line removed from here? Probably mistake, its icon has been replaced in line 111 by application-pdf.
    
    Regarding the export_pdf action, we wanted to have it inserted into the exportMenu, as the visible text "PDF..." suggests. So it shouldn't be added to viewActions but to exportMenu like the other export actions.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43070>

    Use getExportUrl() as in other export routines. You will only a need mimetype then insterad of the hardcoded                            "*pdf|Portable Document Format(*pdf)" message.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43069>

    Use window()->partItem() as said above, and don't use 'this'.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43072>

    For other export types we do not tell the user about success so don't do that here too.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43073>

    Look at how this message is nicer formatted in slotExportAsTextDocument() and go this way too.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment43071>

    Add usage of openExportedDocument() here as in other exports to offer opening the exported document.


- Jarosław Staniek


On July 7, 2014, 8:27 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119075/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 8:27 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added button to report data view that prints report directly to pdf after selecting location 
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiView.h 062552e 
>   kexi/core/KexiView.cpp 7439049 
>   kexi/plugins/reports/kexireportview.h 1823cf8 
>   kexi/plugins/reports/kexireportview.cpp 2d84efc 
> 
> Diff: https://git.reviewboard.kde.org/r/119075/diff/
> 
> 
> Testing
> -------
> 
> After clicking and selecting save location pdf document with report data view content is created
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140707/e99a9a04/attachment.htm>