Review Request 119153: Remove Name Expansion From KoStore

Boudewijn Rempt boud at valdyas.org
Mon Jul 7 12:37:14 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119153/
-----------------------------------------------------------

(Updated July 7, 2014, 11:37 a.m.)


Review request for Calligra.


Changes
-------

Updated to the right diff...


Repository: calligra


Description
-------

In 2002, some code was added to KoStore to add "part" in front of some files if the filename starts with a number. Probably for embedded documents, but the history is unclear. This has been giving trouble ever since, and now we basically always disable the name expansion system -- so remove it.


Diffs (updated)
-----

  filters/libmsooxml/KoOdfExporter.cpp 741585e 
  filters/sheets/excel/import/ExcelImport.cpp 4481178 
  filters/sheets/excel/import/excelimporttoods.cc edfac62 
  filters/sheets/html/htmlimport.cc a59be91 
  filters/stage/powerpoint/PptToOdp.cpp 9520816 
  filters/words/applixword/applixwordimport.cc 6e86dcf 
  filters/words/ascii/AsciiExport.cpp c6b9097 
  filters/words/ascii/AsciiImport.cpp a6057e3 
  filters/words/docx/export/DocxExport.cpp 2880f7b 
  filters/words/docx/export/DocxFile.cpp f1f7ee1 
  filters/words/epub/EpubFile.cpp 1f0b299 
  filters/words/epub/HtmlFile.cpp c1d35d6 
  filters/words/epub/exportepub2.cpp 91a58fd 
  filters/words/epub/exporthtml.cpp ec181d5 
  filters/words/mobi/exportmobi.cpp 93758ca 
  filters/words/msword-odf/mswordodfimport.cpp 1b7e97f 
  krita/plugins/formats/odg/kis_odg_import.cc 6a8b651 
  krita/plugins/formats/ora/ora_converter.cc d8b9e6a 
  krita/plugins/paintops/resourcemanager/KoResourceBundle.cpp 78edb59 
  krita/ui/flake/kis_shape_layer.cc 39789cc 
  krita/ui/flake/kis_shape_selection.cpp 71ec21b 
  krita/ui/kis_clipboard.cc 44b1a90 
  krita/ui/kis_mimedata.cpp 3905f1f 
  libs/main/KoDocument.cpp 675675e 
  libs/odf/KoEmbeddedDocumentSaver.cpp 4ed6e48 
  libs/odf/KoOdfPaste.cpp 1e46546 
  libs/odf/KoStore.h 2b1f4bc 
  libs/odf/KoStore.cpp 0c398ac 
  libs/odf/KoStore_p.h fc830e2 
  libs/odf/tests/storedroptest.cpp 68d51cb 
  plan/kptmaindocument.cpp bc0894c 
  plugins/chartshape/ChartShape.cpp ca42770 
  plugins/dockers/shapecollection/OdfCollectionLoader.cpp f52eeb1 
  plugins/formulashape/KoFormulaShape.cpp 6a6e692 
  words/part/tests/TestRdf.cpp d0b34d9 

Diff: https://git.reviewboard.kde.org/r/119153/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140707/05feca73/attachment.htm>


More information about the calligra-devel mailing list