Review Request 110928: Always save the position of a shape

[Inge Wallin]

> On July 6, 2014, 2:51 p.m., Camilla Boemann wrote:
> > After having read the discussion I come out on the side of dismissing, based on the following:
> > 
> > 1) It is not done as a result of a bug
> > 2) It produces more output xml
> > 3) The spec states what default values are, and we try not to write out default values in other cases.

1. I don't remember anymore how relevant this was to the bug mentioned in the description, but I will look at it again and come back.
2. That is irrelevant since the amount is very small.
3. This might be a good point.  I will look at it again. One possible reason to do it anyway would be for compatibility with other, faulty, ODF consumers but I don't know if that is actually an issue.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110928/#review61727
-----------------------------------------------------------


On June 10, 2013, 7:18 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110928/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 7:18 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When a shape is in the position 0, 0 and there are no other transformations, the position will not be saved back. In other words, there will be an svg:height and svg:width but no svg:x or svg:y.  I noticed this while trying to fix https://bugs.kde.org/show_bug.cgi?id=184727.
> 
> This patch fixes that the code doesn't save the position.  I suggest that we apply it to 2.7 as well and maybe also to 2.6.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.cpp 6d14a8c 
> 
> Diff: https://git.reviewboard.kde.org/r/110928/diff/
> 
> 
> Testing
> -------
> 
> Tested with the file mentioned above.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140706/0c7e9583/attachment.htm>