Review Request 110928: Always save the position of a shape

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110928/#review61720
-----------------------------------------------------------


Ping. Could someone of the discussion participants either push for more discussion to reach for an accepted solution, or should the review request rather be closed? Would close until end of July, if there is no further discussion now.

- Friedrich W. H. Kossebau


On Juni 10, 2013, 7:18 nachm., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110928/
> -----------------------------------------------------------
> 
> (Updated Juni 10, 2013, 7:18 nachm.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When a shape is in the position 0, 0 and there are no other transformations, the position will not be saved back. In other words, there will be an svg:height and svg:width but no svg:x or svg:y.  I noticed this while trying to fix https://bugs.kde.org/show_bug.cgi?id=184727.
> 
> This patch fixes that the code doesn't save the position.  I suggest that we apply it to 2.7 as well and maybe also to 2.6.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.cpp 6d14a8c 
> 
> Diff: https://git.reviewboard.kde.org/r/110928/diff/
> 
> 
> Testing
> -------
> 
> Tested with the file mentioned above.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140706/5b0c7c24/attachment.htm>