Review Request 108481: Temporarily swith to path tool to change shape parameters without double click to switch tool

Friedrich W. H. Kossebau kossebau at kde.org
Sun Jul 6 15:06:27 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108481/#review61715
-----------------------------------------------------------


Given the reservations against the changes in this RR and no further discussion, can we close this RR as discarded? Will do so until end of July, unless someone objects or beats me in closing.

- Friedrich W. H. Kossebau


On Jan. 19, 2013, 9:11 vorm., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/108481/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 9:11 vorm.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> After patch is applied, is a single parameter shape is selected in default tool, parameter handles will be painted. If mouse move on the handles, will temporarily switch to path tool so users can edit shape parameters. In temporary path tool if mouse move off from the handles, current tool will be switched back to default tool.
> 
> Now double click in default tool can be used for other tasks, such as add a new textbox for current shape.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoParameterShape.h 9c0db7a 
>   libs/flake/tools/KoPathTool.h af906bb 
>   libs/flake/tools/KoPathTool.cpp 9dd8caf 
>   libs/flake/tools/KoPathToolFactory.h 2aacfe5 
>   libs/flake/tools/KoPathToolFactory.cpp 1846c86 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp db7c489 
>   plugins/defaultTools/defaulttool/SelectionDecorator.h 83e715e 
>   plugins/defaultTools/defaulttool/SelectionDecorator.cpp 3e16cfa 
> 
> Diff: https://git.reviewboard.kde.org/r/108481/diff/
> 
> 
> Testing
> -------
> 
> works in words, stage, flow, karbon
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140706/328cec0d/attachment.htm>


More information about the calligra-devel mailing list