Review Request 119098: Better highlight of eraser, alpha lock and mirror modal buttons

Boudewijn Rempt boud at valdyas.org
Thu Jul 3 08:32:18 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119098/#review61523
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On July 3, 2014, 7:28 a.m., Ivan Yossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119098/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 7:28 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> We change the button background to highlight color if the mode is activated.
> 
> implemented as a function this is the effect
> https://plus.google.com/104926764783100830207/posts/DinU4TWLs5h
> 
> The only remaining issue is that the color doesn't update if user changes themes.
> 
> 
> Diffs
> -----
> 
>   krita/ui/kis_paintop_box.h cfe66bd 
>   krita/ui/kis_paintop_box.cc df3a99c 
> 
> Diff: https://git.reviewboard.kde.org/r/119098/diff/
> 
> 
> Testing
> -------
> 
> Compiles and doesn't crash krita.
> 
> 
> Thanks,
> 
> Ivan Yossi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140703/63273e32/attachment.htm>


More information about the calligra-devel mailing list