Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118984/#review61464
-----------------------------------------------------------


This review has been submitted with commit 8f83fa3a0996c8ab5aa78ef539bdc88685399264 by Jaroslaw Staniek to branch master.

- Commit Hook


On June 29, 2014, 9:14 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118984/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 9:14 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> KoPart argument of KoDocument and descendants should not be optional
> 
> Currently KoPart is required, there is even assertion for, so express this in the API.
> Current API apparently caused one crash (in spreadsheet plugin of Kexi).
> 
> Also put 2 more assertions as early as possible.
> 
> Finally, fixed outdated docs.
> 
> 
> Diffs
> -----
> 
>   karbon/ui/KarbonDocument.cpp eed34ea 
>   krita/ui/kis_doc2.h 657fabc 
>   krita/ui/kis_doc2.cc aad9ae5 
>   plan/kptmaindocument.h 5c7e44d 
>   plan/kptmaindocument.cpp 9b9f485 
>   sheets/DocBase.h 946e9cd 
>   sheets/DocBase.cpp b01a200 
>   sheets/part/Doc.h bf8341c 
>   sheets/part/Doc.cpp 44fd7ab 
>   words/part/KWDocument.cpp 533b8e1 
> 
> Diff: https://git.reviewboard.kde.org/r/118984/diff/
> 
> 
> Testing
> -------
> 
> Builds, nobody is used the argument-less constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed)
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140702/e5b69f53/attachment.htm>