Review Request 119075: Added printing reports to pdf feature in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119075/#review61444
-----------------------------------------------------------



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42779>

    + check if user pressed cancel (if so, fileName.isEmpty())



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42776>

    Or even better use KUrl("kfiledialog:///LastVisitedPDFExportPath/" + {REPORTCAPTION})
    
    where {REPORTCAPTION} is taken from the object's caption.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42778>

    parent can be 'this', right?



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42775>

    Typically for PDF:
    + use QPrinter::HighResolution
    + use setColorMode(QPrinter::Color)
    



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42777>

    parent can be 'this', right?


- Jarosław Staniek


On July 1, 2014, 6:47 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119075/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:47 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added button to report data view that prints report directly to pdf after selecting location 
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.h 4d7d017 
>   kexi/plugins/reports/kexireportview.cpp e69d9c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119075/diff/
> 
> 
> Testing
> -------
> 
> After clicking and selecting save location pdf document with report data view content is created
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140701/74cab743/attachment.htm>