Review Request 119075: Added printing reports to pdf feature in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119075/#review61420
-----------------------------------------------------------


Good start!
In principle I propose to use term Export As PDF. Even if technically (as we discussed) this is close to printing, for users it's exporting to format like to any other.



kexi/plugins/reports/kexireportview.h
<https://git.reviewboard.kde.org/r/119075/#comment42751>

    -> slotExportAsPdf



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42756>

    not needed, perhaps a is enough 



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42752>

    Use "application-pdf" icon and i18n("PDF...") as text



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42754>

    -> export_pdf



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42753>

    -> Export as PDF



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42755>

    -> Exports the current report as PDF



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42758>

    As per recent integration effort (2014) please try to use higher-level KoFileDialog.



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42763>

    use KUrl("kfiledialog:///LastVisitedPDFExportPath")



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42764>

    Pdf -> PDF
    and use Title Capitalization here (http://techbase.kde.org/Projects/Usability/HIG/Capitalization)



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42765>

    move to 208



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42766>

    Always check the result!
    Use QScopedPointer instead of a raw pointer



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42767>

    1. Check the result. If fails, display error instead of silent exit. See slotExportAsTextDocument() as inspiration.
    



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42768>

    not needed when QScopedPointer is used



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42769>

    no extra space



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42770>

    no extra spaces
    append '.'



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/119075/#comment42771>

    no extra spaces
    Status info -> Success


- Jarosław Staniek


On July 1, 2014, 6:47 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119075/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:47 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added button to report data view that prints report directly to pdf after selecting location 
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.h 4d7d017 
>   kexi/plugins/reports/kexireportview.cpp e69d9c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119075/diff/
> 
> 
> Testing
> -------
> 
> After clicking and selecting save location pdf document with report data view content is created
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140701/43dd5354/attachment.htm>