Review Request 115195: Fix of BUG:317648

[Nicolas Brack]

> On Jan. 21, 2014, 7:54 p.m., Nicolas Brack wrote:
> > This is incredible how long can breakpoint->run->check cycles can last when you do not know the code that well.
> > Still no commit access since yesterday obviously.
> >
> 
> Boudewijn Rempt wrote:
>     It looks good -- but it might actually clash with a patch that I got from someone else yesterday. Well, actually, it seems both patches are doing the same thing :-).
>     
>     As for commit access, basically, once you've done a few patches and intend to go on hacking on krita, you need to follow http://techbase.kde.org/Contribute/Get_a_Contributor_Account
> 
> Boudewijn Rempt wrote:
>     Ah. the patch by Wolthera indeed already added this line... Which sort of confirms it's the right thing to do :-)

Actually last night I though this was not a very satisfying fix because the cursor has a noisy movement of the "Simple color selector" cursor, that gets worse when the selector is smaller.
I envision a fix by resetting the coordinates of the component only when not modifying the whole color picker by a click/move on it.  I'm a bit busy right now, so it will wait.
Still, that fix is better than the original bug.


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115195/#review47927
-----------------------------------------------------------


On Jan. 23, 2014, 6:26 p.m., Nicolas Brack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115195/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 6:26 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 317648
>     http://bugs.kde.org/show_bug.cgi?id=317648
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> BUG:317648: Fix small circle shifting in selectors
> 
> With the fix, "Simple color selector" doesn't reset to the value it has before a picking event occured when using the other color selector component to change the color.
> This caused for example the saturation and luminosity of the main square component to "jump" when changing the hue with a ring component.
> Similar to BUG:287001, similarly solved.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_simple.cpp 12117fd 
> 
> Diff: https://git.reviewboard.kde.org/r/115195/diff/
> 
> 
> Testing
> -------
> 
> Launch krita, open an image, pick a color, change the hue.
> 
> 
> Thanks,
> 
> Nicolas Brack
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140123/2a5ffbe0/attachment.htm>