Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

Andrius da Costa Ribas andriusmao at gmail.com
Thu Jan 23 00:57:00 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115108/#review48089
-----------------------------------------------------------


This one is not needed anymore after review #115128 got submitted, should I discard this one?

- Andrius da Costa Ribas


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115108/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:42 a.m.)
> 
> 
> Review request for Calligra and kdewin.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch fixes the build issues on MinGW due to mode_t typedef and struct timezone being defined in both kdewin and winquirks.
> 
> 
> Diffs
> -----
> 
>   winquirks/sys/time.h e6852ca 
>   winquirks/unistd.h 82a9ab4 
> 
> Diff: https://git.reviewboard.kde.org/r/115108/diff/
> 
> 
> Testing
> -------
> 
> Tested building on both MSVC and MinGW.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140123/1c9f7a07/attachment.htm>


More information about the calligra-devel mailing list