Review Request 115133: Make Shift+Return and Escape shortcuts work in table and form data views

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115133/#review47829
-----------------------------------------------------------

Ship it!


Shortcuts work fine here with this patch, no apparent side effects. Checked with both MSVC and MinGW builds, with both tables and forms.

- Andrius da Costa Ribas


On Jan. 19, 2014, 10:50 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115133/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 10:50 p.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Bugs: 330138
>     http://bugs.kde.org/show_bug.cgi?id=330138
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> In Kexi 2.x there's regression compared to Kexi 1.x. Shortcuts such as Shift+Return (save record edit) or Escape (cancel field/record edit) do not work in table and form data views.
> 
> For 2.8+
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp 248089780737bb419abd908d237df46a246e25ee 
>   kexi/widget/dataviewcommon/kexidataawareview.h aa444653a402c139e289ca5fd1f46d2b68fdfa6b 
>   kexi/widget/dataviewcommon/kexidataawareview.cpp 1bc6a27ebcf2fa4251a13aded7b0e720cea732ad 
> 
> Diff: https://git.reviewboard.kde.org/r/115133/diff/
> 
> 
> Testing
> -------
> 
> Tested with tables and forms
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140120/d972edec/attachment.htm>