Review Request 115115: Fix for bug #327110 - Crash when trying to insert notes

[Thorsten Zachmann]

> On Jan. 19, 2014, 6:12 a.m., Thorsten Zachmann wrote:
> > Nice patch please commit. Cool to see you around again.
> 
> Fredy Yanardi wrote:
>     Thanks for reviewing, shall I commit it to 2.8 branch as well?

Yes please


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115115/#review47664
-----------------------------------------------------------


On Jan. 19, 2014, 3:58 a.m., Fredy Yanardi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115115/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:58 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 327110
>     http://bugs.kde.org/show_bug.cgi?id=327110
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix for bug #327110 - Crash when trying to insert notes (happen on file created by LibreOffice). The crash is because KPrViewModeNotes shapeRemoved() slot is not called when the placeholder is removed (on click). This should also fix bug that shape added / removed to notes view is not repainted immediately.
> 
> 
> Diffs
> -----
> 
>   flow/part/FlowPart.cpp 3360e44 
>   libs/kopageapp/KoPAView.h b1efaf1 
>   libs/kopageapp/KoPAView.cpp aa735cc 
>   stage/part/KPrPart.cpp b100a8c 
> 
> Diff: https://git.reviewboard.kde.org/r/115115/diff/
> 
> 
> Testing
> -------
> 
> Tested by opening presentation file created by LibreOffice.
> 
> 
> Thanks,
> 
> Fredy Yanardi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140119/738d9fe1/attachment.htm>