Review Request 114986: Fix usage of KDE4_ENABLE_EXCEPTIONS
Andrius da Costa Ribas
andriusmao at gmail.com
Fri Jan 17 18:51:57 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114986/
-----------------------------------------------------------
(Updated Jan. 17, 2014, 6:51 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra, kdewin and Boudewijn Rempt.
Repository: calligra
Description
-------
${KDE4_ENABLE_EXCEPTIONS} should go into CMAKE_CXX_FLAGS instead of add_definitions, otherwise the same flags get added also into resource compiler "rc.exe" where this flag is unknown.
A similar error is described in: http://www.cmake.org/pipermail/cmake/2008-June/022381.html - this patch makes the same of what ksirk currently does.
Diffs
-----
krita/CMakeLists.txt e825c03
Diff: https://git.reviewboard.kde.org/r/114986/diff/
Testing
-------
Tested using MSVC.
Thanks,
Andrius da Costa Ribas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140117/4a2f7341/attachment.htm>
More information about the calligra-devel
mailing list