Review Request 114994: Fix bug: data is not saved in form combo boxes

[Jarosław Staniek]

> On Jan. 13, 2014, 12:54 a.m., Andrius da Costa Ribas wrote:
> > Applying this patch solves the updating issue and also focus is not "trapped" anymore when using the tab key.
> > Two weird behaviors happen, though:
> > * when losing focus the text inside the combo box is still highlighted
> > * even with the combo box focused it's not possible to change the values without using the mouse (combo box should react to arrow keys and spacebar).

That's OK, the focus issues have been noted in https://bugs.kde.org/show_bug.cgi?id=329892; that will be different review. Thanks.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114994/#review47284
-----------------------------------------------------------


On Jan. 13, 2014, 12:03 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114994/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 12:03 a.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Bugs: 329141
>     http://bugs.kde.org/show_bug.cgi?id=329141
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix bug: data is not saved in form combo boxes
> 
> Subwidget is not focusable but the form requires focusable
> widget in order to manage data updates so let it be this KexiDBComboBox.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/widgets/kexidbcombobox.cpp 062cabb16dc4f029f81c877b4eb59c14b1f0a60a 
> 
> Diff: https://git.reviewboard.kde.org/r/114994/diff/
> 
> 
> Testing
> -------
> 
> Tested with the combotestcase.kexi from https://bugs.kde.org/show_bug.cgi?id=329141
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140113/6e46daf0/attachment.htm>