Review Request 114986: Fix usage of KDE4_ENABLE_EXCEPTIONS

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114986/#review47295
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On Jan. 12, 2014, 9:12 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114986/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 9:12 p.m.)
> 
> 
> Review request for Calligra, kdewin and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> ${KDE4_ENABLE_EXCEPTIONS} should go into CMAKE_CXX_FLAGS instead of add_definitions, otherwise the same flags get added also into resource compiler "rc.exe" where this flag is unknown.
> 
> A similar error is described in: http://www.cmake.org/pipermail/cmake/2008-June/022381.html - this patch makes the same of what ksirk currently does.
> 
> 
> Diffs
> -----
> 
>   krita/CMakeLists.txt e825c03 
> 
> Diff: https://git.reviewboard.kde.org/r/114986/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140113/4bc34da0/attachment.htm>