Review Request 116009: Maintained the Aspect ratio of height and width during pdf import

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116009/#review51006
-----------------------------------------------------------


Yes, this is quite right! However, it's not complete -- the dialog needs one of those chain/broken chain buttons to disable the synching, like in the image scale dialog.

- Boudewijn Rempt


On Feb. 24, 2014, 10:34 a.m., Swarn Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116009/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:34 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 297254 and Bug
>     http://bugs.kde.org/show_bug.cgi?id=297254
>     http://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added two functions to maintain Aspect Ratio of height and width during pdf import.
> 
> -heightAspectRatio()
> -widthAspectRatio()
> 
> Tried to do it with c++11 lamba functions but couldn't figure it how? Compiler said the function is ambiguous.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/formats/pdf/kis_pdf_import_widget.h 0458815 
>   krita/plugins/formats/pdf/kis_pdf_import_widget.cpp 3bba643 
> 
> Diff: https://git.reviewboard.kde.org/r/116009/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Swarn Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140227/c80e6a0a/attachment.htm>