Review Request 116054: Remove some irritating warnings

Yue Liu yue.liu at mail.com
Tue Feb 25 19:36:13 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116054/#review50872
-----------------------------------------------------------

Ship it!


Ship It!

- Yue Liu


On Feb. 25, 2014, 7:03 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116054/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 7:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch removes some very irritating warnings about missing definitions of __x86_64__ and __ppc64__. Problem is that they were given in *every* compiled file.
> 
> Ok to backport?
> 
> 
> Diffs
> -----
> 
>   KoConfig.h.cmake c56c3ac 
> 
> Diff: https://git.reviewboard.kde.org/r/116054/diff/
> 
> 
> Testing
> -------
> 
> No warnings anymore and seems not to affect anything else.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140225/80adfa5b/attachment.htm>


More information about the calligra-devel mailing list