Review Request 115314: Fix crash with custom sized reports

[Jarosław Staniek]

> On Feb. 20, 2014, 11:12 a.m., Jarosław Staniek wrote:
> > BTW, as this looks like an improvement that will take longer time than expected there are no chances to release it for 2.8.0. How about filing a "Add support for custom page sizes" wish in bugs.kde.org with 2.8.2 as an additional milestone? Today I moved quite a few fixes to this milestone.
> 
> Jarosław Staniek wrote:
>     However, for 2.8.0 at least a crashfix can be added.

Did that for 2.8.0: http://commits.kde.org/calligra/eca8b874ae65520ca6a86ea52c5f79cb389662bf
After the release it can be reverted.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115314/#review50330
-----------------------------------------------------------


On Feb. 16, 2014, 6:11 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115314/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 6:11 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch enables "Custom" sized reports which were not working before.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 7644c1d 
> 
> Diff: https://git.reviewboard.kde.org/r/115314/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC, with both Plan and Kexi reports.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140220/deb03c18/attachment.htm>