Review Request 115855: Do not add tablename in a generated SQL when not needed
Jarosław Staniek
staniek at kde.org
Thu Feb 20 09:54:19 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115855/#review50310
-----------------------------------------------------------
Ship it!
Marking it as reviewed, 2.8 tagging in 2 days. I've been using this patch a couple of days.
- Jarosław Staniek
On Feb. 17, 2014, 10:34 p.m., Jarosław Staniek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115855/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 10:34 p.m.)
>
>
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
>
>
> Bugs: 331259
> http://bugs.kde.org/show_bug.cgi?id=331259
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Do not add tablename in a generated SQL when not needed
>
>
> Diffs
> -----
>
> libs/db/connection.cpp 27d8f462db832643002bd7f43ba3548b2cf0101b
>
> Diff: https://git.reviewboard.kde.org/r/115855/diff/
>
>
> Testing
> -------
>
> Tested with the attached db
>
>
> Thanks,
>
> Jarosław Staniek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140220/25f84b03/attachment.htm>
More information about the calligra-devel
mailing list