Review Request 115314: Fix crash with custom sized reports

[Jarosław Staniek]

> On Feb. 5, 2014, 11:48 a.m., Jarosław Staniek wrote:
> > libs/koreport/wrtembed/KoReportDesigner.cpp, line 239
> > <https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line239>
> >
> >     Check this value, if it's "Custom" or "" then perform steps for the custom size.
> 
> Andrius da Costa Ribas wrote:
>     lowercase "custom", actually

right


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115314/#review49010
-----------------------------------------------------------


On Feb. 16, 2014, 6:11 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115314/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 6:11 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch enables "Custom" sized reports which were not working before.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 7644c1d 
> 
> Diff: https://git.reviewboard.kde.org/r/115314/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC, with both Plan and Kexi reports.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140219/a542b2c4/attachment.htm>