mixing double and qreal types

Rex Dieter rdieter at math.unl.edu
Wed Feb 12 14:00:10 GMT 2014


Rex Dieter wrote:

> FYI,
> 
> calligra-2.7.92 fails to build on arm platform (where qreal != double).
> 
> I think it comes from this commit:
> 
> 
https://projects.kde.org/projects/calligra/repository/revisions/3b54859a0514fc215cb9c46fc17acd13d2f700be
> 
> Please be careful mixing double and qreal types.  Thanks.
> 
> I'll try to help work on a patch soon (attached is what I have so far,
> untested).

OK, that initial one wasn't good enough, but this one at least compiles:

http://pkgs.fedoraproject.org/cgit/calligra.git/tree/calligra-2.7.92-qreal.patch

In short, it modifies
krita/image/kis_convolution_worker_spatial.h
to replace all occurances of double with qreal

How would folks prefer to proceed here?

1.  reviewboard?
2.  review/comment here
3.  just commit
4.  some other better idea?

-- Rex




More information about the calligra-devel mailing list