Review Request 121655: Add overloads (non-raw queries and params) for convenience KexiDB functions

Roman Shtemberko shtemberko at gmail.com
Wed Dec 31 09:09:01 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121655/#review72820
-----------------------------------------------------------

Ship it!


Ship It!

- Roman Shtemberko


On Дек. 23, 2014, 9:50 п.п., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121655/
> -----------------------------------------------------------
> 
> (Updated Дек. 23, 2014, 9:50 п.п.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Add overloads (non-raw queries and params) for convenience KexiDB functions
> 
> For:
> - Utils::rowCount()
> - Connection::querySingleRecord()
> - Connection::querySingleString()
> - Connection::querySingleNumber()
> - Connection::queryStringList()
> 
> By the way, remove unsafe use of static variables in querySingleNumber().
> 
> Needed to fix the "Can't export data for parametrized query to a .csv file" bug (151504)
> see https://git.reviewboard.kde.org/r/121443/
> 
> 
> Diffs
> -----
> 
>   libs/db/connection.h 0ed171d857b93060398787226698b3c67758b024 
>   libs/db/connection.cpp c422f78ca0f6c8a5f767e6892d0468821cccc567 
>   libs/db/utils.h 9bea691a4af95447983ddc0f093c1ae4b4aeb7e6 
>   libs/db/utils.cpp 923a401f7f4265d19c699db3d35046f21914747f 
> 
> Diff: https://git.reviewboard.kde.org/r/121655/diff/
> 
> 
> Testing
> -------
> 
> Tested with large .kexi files; these methods are used there and Kexi still works OK
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141231/993cc659/attachment.htm>


More information about the calligra-devel mailing list