Review Request 121752: Remove the ColorDocker and the KoUniColorChooser

Boudewijn Rempt boud at valdyas.org
Tue Dec 30 10:32:45 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121752/
-----------------------------------------------------------

(Updated Dec. 30, 2014, 10:32 a.m.)


Review request for Calligra.


Bugs: https://bugs.kde.org/show_bug.cgi?id=342328
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=342328


Repository: calligra


Description
-------

The colordocker has been disabled since 2010 because it is unfinished. It was the last user of KoUniColorChooser class, since the KoDualColorButton is now using KDE's color selector because users need the color picker in it.


Diffs
-----

  libs/widgets/CMakeLists.txt 55ed78f 
  libs/widgets/KoDualColorButton.h 959d002 
  libs/widgets/KoUniColorChooser.h b458024 
  libs/widgets/KoUniColorChooser.cpp 303d0a1 
  libs/widgets/KoXYColorSelector.h 2b06644 
  libs/widgets/KoXYColorSelector.cpp 4e0562f 
  plugins/dockers/CMakeLists.txt 889f4f2 
  plugins/dockers/Plugin.cpp 777bfe9 
  plugins/dockers/colordocker/ColorDocker.h e945d96 
  plugins/dockers/colordocker/ColorDocker.cpp 5e0f8a7 
  plugins/dockers/colordocker/ColorDockerFactory.h a43af2e 
  plugins/dockers/colordocker/ColorDockerFactory.cpp e559810 

Diff: https://git.reviewboard.kde.org/r/121752/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141230/25a06c21/attachment.htm>


More information about the calligra-devel mailing list