Review Request 121656: Krita - Fix weak shared pointer copy constructor and assignment

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121656/#review72484
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On Dec. 24, 2014, 12:34 a.m., Stefano Bonicatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121656/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 12:34 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Now is possible to copy and assign an invalid weak pointer to a shared pointer or another weak pointer.
> Cleaned up a couple of redundant checks.
> Added some testcases to test the validity of the change.
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_shared_ptr.h 85aee50 
>   krita/image/tests/kis_shared_ptr_test.h 9c9a35f 
>   krita/image/tests/kis_shared_ptr_test.cpp 6f44b1c 
> 
> Diff: https://git.reviewboard.kde.org/r/121656/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine.
> Tests are all passing.
> 
> 
> Thanks,
> 
> Stefano Bonicatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141224/53b9dfde/attachment.htm>