Review Request 120935: Add 'Value' property to report items which can contain static data if not bound to a field

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120935/#review72462
-----------------------------------------------------------


Very good! Please update for the current calligra/2.9, there are two minor conflicts.

For reference, we're talking about task #1 at https://community.kde.org/Kexi/Junior_Jobs/Small_report_improvements#The_Tasks.


libs/koreport/common/krsize.h
<https://git.reviewboard.kde.org/r/120935/#comment50500>

    OK even if I don't like bundling the KR* data structures with KoProperties (what can be improved later because it's not easy -- I tried :).



libs/koreport/items/check/KoReportItemCheck.h
<https://git.reviewboard.kde.org/r/120935/#comment50501>

    let's remove the comment then



libs/koreport/items/check/KoReportItemCheck.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50502>

    let's remove the comment then



libs/koreport/items/check/KoReportItemCheck.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50505>

    NOTE1
    
    or "value used if not bound to a field" ?
    
    I believe "static" may be too advanced term to our users...



libs/koreport/items/field/KoReportItemField.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50506>

    see NOTE1



libs/koreport/items/image/KoReportItemImage.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50508>

    We're keeping the name for backward-compat, that's OK.
    
    I propose to set the description to the same value as in NOTE1.
    Caption could be just i18n("Value"), "Static Image" comment would confuse translators.



libs/koreport/items/text/KoReportItemText.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50507>

    see NOTE1



libs/koreport/items/text/KoReportItemText.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50509>

    I think it's fixed already, if so please update the patch;
    
    commit cdf4f0befa818c07601cd28768613482c63dbea1
    Author: Friedrich W. H. Kossebau <kossebau at kde.org>
    Date:   Sat Nov 1 03:40:31 2014 +0100



libs/koreport/wrtembed/KoReportDesignerItemBase.h
<https://git.reviewboard.kde.org/r/120935/#comment50503>

    Could you add docs?



libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50504>

    Can't we re-use dataSourceAndObjectTypeName() here?
    
    In any case, this arithmetic isn't acceptable.



plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50510>

    Per convention, QString() is enough instead of ""



plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50511>

    Per convention, QString() is enough instead of ""



plugins/reporting/barcode/KoReportItemBarcode.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50512>

    see NOTE1


- Jarosław Staniek


On Nov. 1, 2014, 9:45 a.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120935/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 9:45 a.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added a new property to the following report items:
> check
> field
> text
> barcode
> Renamed image property 'Static Image' to Value but left saving/loading the same for compatibility.
> 
> Added a method to KoReportDesignerItemRectBase to store a string used for rendering data in the report designer.
> Report designer shows the static data if used
> 
> Includes a bug fix in KRSize which meant recursion was possible
> Includes a small fix to Text item which caused an infinite loop.
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/barcode/KoReportItemBarcode.cpp 7c6df3928b95277927bac3ad76fb7e6b87c7a3d0 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp 43acbd067b9f41a7ef36ceedfc9578bbd8cd84b8 
>   plugins/reporting/barcode/KoReportItemBarcode.h f0e7f609e33f3e4a8dc7f84bddedf73e6f236541 
>   libs/koreport/common/krsize.h cc319c0542977e4fa722f337ef0a020fdff2f2c8 
>   libs/koreport/common/krsize.cpp f8c0d7b71fc2bc04c7b72b2c67d70b6564d8c5b4 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp ac628616b52b4769232a55af07a51bea9fd80c0a 
>   libs/koreport/items/check/KoReportItemCheck.h dcbe271a623b143c6159b00cb5b82ea5cdfcca29 
>   libs/koreport/items/check/KoReportItemCheck.cpp 5bc4318d1906df63917f871c78e00442b8ca92e4 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp f386f9b99c9584f1122fbee542fb708bf5121f16 
>   libs/koreport/items/field/KoReportItemField.h 31cc02526672a57211c8594643f66cd46766d4a4 
>   libs/koreport/items/field/KoReportItemField.cpp d34ec1f9ac2aeb05374a1dca1704244bb27335ee 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp b129299e160c65d1d9f6ed691800e1d6095a5364 
>   libs/koreport/items/image/KoReportItemImage.cpp 65d26cce3c29cb42eb8dc541063a4a52ab3bd6de 
>   libs/koreport/items/text/KoReportDesignerItemText.h 3d79fbf7c14493e66e320a76266369f92a5af446 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 7af69c4840bd910a7a8ee158d2c89d5f9096ed2a 
>   libs/koreport/items/text/KoReportItemText.h a43e7f8775bb456c297253eb246d6140a2a86c11 
>   libs/koreport/items/text/KoReportItemText.cpp 20b157593bc4f35c1206e064bb097accacae5dcb 
>   libs/koreport/wrtembed/KoReportDesignerItemBase.h 5d43131a78c4697bf511f18103825bcf8bad8657 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 73b7a7073bc5f2fe22266c21ef854fcd13df7854 
> 
> Diff: https://git.reviewboard.kde.org/r/120935/diff/
> 
> 
> Testing
> -------
> 
> Loading/saving each item type
> Testing each type with:
> value set, value not set and data source set, data source set and value set
> 
> Items display correctly in designer
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141223/43436c9f/attachment.htm>